Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Meraki vMX & Convert to Az cmdlets #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ScottMonolith
Copy link

I have taken PR 8 from @myhomenwlab and modified it - this now supports the Az cmdlets, there is some additional logging and now Function App runtime version ~4 can be utilized in Azure.

myhomenwlab and others added 3 commits February 8, 2022 21:18
* Created a directory for Time Trigger and moved the related files.

* Created a requirements.psd1 file to download the required modules.

* Added information on the following issue.

  No parameter defined in the script or function for the input binding 'Timer'.Stack: · Issue Azure#7 · Azure/ha-nva-fo
  Azure#7

* The Resoruce Group of Meraki vMX is created on a per-instance basis. Therefore, the variable FWRGNAME is divided into FW1RGNAME and FW2RGNAME.

* Added Meraki-specific supplementary information to README.
@ScottMonolith
Copy link
Author

@microsoft-github-policy-service agree company="Monolith"

@ScottMonolith
Copy link
Author

FYI the Send-AlertMessage function still does not work - it was not a priority for my company as we will not generate alerts from this function app directly. The Resolve-DnsName cmdlet is not available for some reason and I did not put much time into figuring out how to solve that problem.

@sneakyrussian
Copy link

sneakyrussian commented Aug 14, 2023

I have taken PR 8 from @myhomenwlab and modified it - this now supports the Az cmdlets, there is some additional logging and now Function App runtime version ~4 can be utilized in Azure.

Hi Scott,

Any chance you could share a Github URL to your latest code and instructions, please?

Many thanks,

SR

@ScottMonolith
Copy link
Author

ScottMonolith commented Aug 14, 2023

Hi @sneakyrussian - this is it, the PR you are commenting on is my latest code. You can click the link and go to my repo, but I haven't made any other updates there.

You can read some additional comments on Issue #7 - I'm not sure why expoearchie had problems with my changes though.

@sneakyrussian
Copy link

sneakyrussian commented Aug 14, 2023 via email

@sneakyrussian
Copy link

sneakyrussian commented Aug 15, 2023

Hi @ScottMonolith, just tried using your code and seeing the following failures in App Insights:

15/08/2023, 09:39:39
Exception while executing function: Functions.MyTimerTrigger
Problem Id:System.Management.Automation.CommandNotFoundException at System.Management.Automation.CommandDiscovery.LookupCommandInfo

As mentioned in my previous response, I don't seem to have MyTimerTrigger folder synced through "External GIT". Any chance you could shed some light, please? Thanks a lot in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants