Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add, remove finalizer for CRB in Scheduler and scheduler watcher for CRB #924

Merged
merged 22 commits into from
Nov 5, 2024
Merged

feat: add, remove finalizer for CRB in Scheduler and scheduler watcher for CRB #924

merged 22 commits into from
Nov 5, 2024

Conversation

Arvindthiru
Copy link
Contributor

@Arvindthiru Arvindthiru commented Oct 18, 2024 •
edited
Loading

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

  • Adding scheduler clean up finalizers for CRBs when CRBs are created in a scheduling cycle
  • Removing scheduler clean up finalizers for CRBs when CRBs are deleting with deleting timestamp
  • Added CRB scheduler watcher to pick up deleting CRBs and enqueue CRP name to trigger scheduling cycle, also added watcher IT
  • Added logic to clean up CRBs, by removing scheduler clean up finalizer when CRP is deleting

These changes are needed for the new PlacementEviction API

@Arvindthiru Arvindthiru marked this pull request as ready for review October 25, 2024 16:47
@Arvindthiru Arvindthiru changed the title feat: add, remove finalizer for CRB in Scheduler feat: add, remove finalizer for CRB in Scheduler and scheduler watcher for CRB Oct 25, 2024
ryanzhang-oss
ryanzhang-oss reviewed Oct 25, 2024
View reviewed changes
pkg/scheduler/framework/framework.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
ryanzhang-oss
ryanzhang-oss reviewed Oct 31, 2024
View reviewed changes
pkg/scheduler/framework/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/framework_test.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Show resolved Hide resolved
@Arvindthiru Arvindthiru merged commit 848ada9 into Azure:main Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanzhang-oss ryanzhang-oss ryanzhang-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arvindthiru @ryanzhang-oss