-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interface: add APIs for eviction/disruption budget #911
Conversation
Internal only: please also see the mini UX doc for further details about this API (ping me if a link hasn't been sent). |
0d337ca
to
2db65ec
Compare
91f808e
to
7dce740
Compare
One concern: for CRPPDB spec validation I'm planning, On adding a validating webhook configuration if user specified both minAvailable and maxUnavailable Should we also add a condition for CRPPDB to mention whether it's valid or invalid, to surface the fact the CRPPDB is invalid in the case where validating webhook config is not present ? |
Upgrading kindest node image to use 1.30 throws this error when I tried to apply the new CRD, Error from server (Forbidden): error when creating "./config/crd/bases/placement.kubernetes-fleet.io_clusterresourceplacementdisruptionbudgets.yaml": admission webhook "fleet.customresourcedefinition.guardrail.validating" denied the request: user: 'kubernetes-admin' in 'groups: [kubeadm:cluster-admins system:authenticated]' is not allowed to CREATE resource apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/: /clusterresourceplacementdisruptionbudgets.placement.kubernetes-fleet.io This requires fixes across the repo and E2E tests, Will handle this update in a separate PR |
Description of your changes
This PR adds the APIs for supporting eviction and disruption budget.
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Applied new resources on a kind cluster,
Special notes for your reviewer
N/A