Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface: add APIs for eviction/disruption budget #911

Merged
merged 14 commits into from
Oct 22, 2024

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Aug 29, 2024

Description of your changes

This PR adds the APIs for supporting eviction and disruption budget.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Applied new resources on a kind cluster,

image
image

Special notes for your reviewer

N/A

@michaelawyu
Copy link
Contributor Author

Internal only: please also see the mini UX doc for further details about this API (ping me if a link hasn't been sent).

circy9
circy9 previously approved these changes Sep 27, 2024
ryanzhang-oss
ryanzhang-oss previously approved these changes Oct 11, 2024
@Arvindthiru
Copy link
Contributor

Arvindthiru commented Oct 17, 2024

One concern: for CRPPDB spec validation I'm planning,

On adding a validating webhook configuration if user specified both minAvailable and maxUnavailable
Unexpected error in the eviction controller (just in case user deletes the validating webhook configuration)

Should we also add a condition for CRPPDB to mention whether it's valid or invalid, to surface the fact the CRPPDB is invalid in the case where validating webhook config is not present ?

apis/placement/v1alpha1/disruptionbudget_types.go Outdated Show resolved Hide resolved
apis/placement/v1alpha1/eviction_types.go Outdated Show resolved Hide resolved
apis/placement/v1alpha1/eviction_types.go Outdated Show resolved Hide resolved
apis/placement/v1alpha1/disruptionbudget_types.go Outdated Show resolved Hide resolved
ryanzhang-oss
ryanzhang-oss previously approved these changes Oct 19, 2024
@Arvindthiru
Copy link
Contributor

Arvindthiru commented Oct 22, 2024

Upgrading kindest node image to use 1.30 throws this error when I tried to apply the new CRD,

Error from server (Forbidden): error when creating "./config/crd/bases/placement.kubernetes-fleet.io_clusterresourceplacementdisruptionbudgets.yaml": admission webhook "fleet.customresourcedefinition.guardrail.validating" denied the request: user: 'kubernetes-admin' in 'groups: [kubeadm:cluster-admins system:authenticated]' is not allowed to CREATE resource apiextensions.k8s.io/v1, Kind=CustomResourceDefinition/: /clusterresourceplacementdisruptionbudgets.placement.kubernetes-fleet.io

This requires fixes across the repo and E2E tests, Will handle this update in a separate PR

@ryanzhang-oss ryanzhang-oss merged commit 1d28a09 into Azure:main Oct 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants