Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: work agent track availability #689

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

ryanzhang-oss
Copy link
Contributor

Description of your changes

Support track resource availability on work agent and reflect it on the work status.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@ryanzhang-oss ryanzhang-oss marked this pull request as draft February 21, 2024 08:30
@ryanzhang-oss ryanzhang-oss marked this pull request as ready for review February 23, 2024 01:50
@ryanzhang-oss ryanzhang-oss marked this pull request as draft February 23, 2024 01:52
@ryanzhang-oss ryanzhang-oss force-pushed the adv-rollout branch 5 times, most recently from e921f5e to 41bc6e4 Compare February 28, 2024 21:34
@ryanzhang-oss ryanzhang-oss marked this pull request as ready for review February 28, 2024 21:34
pkg/controllers/work/apply_controller.go Outdated Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Outdated Show resolved Hide resolved
pkg/controllers/work/apply_controller_test.go Show resolved Hide resolved
pkg/controllers/work/apply_controller_test.go Show resolved Hide resolved
pkg/controllers/work/apply_controller_test.go Show resolved Hide resolved
pkg/controllers/work/apply_controller_test.go Show resolved Hide resolved
pkg/controllers/workgenerator/controller.go Outdated Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Show resolved Hide resolved
// the last three actions types means we start to track the resources
switch action {
case manifestCreatedAction:
applyCondition.Reason = string(manifestCreatedAction)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some human readable messages, something like

"Manifest has just been updated and in the processing of checking its availability"?

pkg/controllers/work/apply_controller.go Outdated Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Show resolved Hide resolved
pkg/controllers/work/apply_controller.go Show resolved Hide resolved
Copy link

There was an error handling pipeline event 6b9ef010-a27a-4dbd-bd9b-f5d892e5a168.

@zhiying-lin zhiying-lin merged commit 6b2b489 into Azure:main Mar 13, 2024
11 checks passed
@ryanzhang-oss ryanzhang-oss deleted the adv-rollout branch July 10, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants