fix: add dedicated status code for identifying clusters that have been selected #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelawyu
changed the title
zhiying-lin
previously approved these changes
Sep 27, 2023
|
Merged to unblock the progress. Approval acquired previously; the test is failing due to a rollout controller integration test issue, which will be addressed separately. If there's any concern, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes an issue that, when a policy snapshot is scheduled for multiple times, clusters which have been selected before will be considered as a filtered cluster and included in the status accordingly.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Not an urgent issue; affecting the status only.