Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace STJ package with Newtonsoft #995

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Replace STJ package with Newtonsoft #995

merged 2 commits into from
Oct 16, 2023

Conversation

nytian
Copy link
Collaborator

@nytian nytian commented Oct 13, 2023

The System.Text.Json package refers to Systems.Buffer which is not supported in DurableFunctions V1 host. Replace this package with Newtonsoft.

@nytian nytian requested review from davidmrdavid and bachuv October 13, 2023 22:39
@nytian
Copy link
Collaborator Author

nytian commented Oct 13, 2023

Please ignore the servicebus pipeline. That's the pipeline I added for df v3 tests. I canceled that one and then it becomes failure :(

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. As Varshi already mentioned, let's validate using the Functions V1 smoke test before merging.

@nytian
Copy link
Collaborator Author

nytian commented Oct 16, 2023

Tested with smoketestsv1 and it works at my end.

@nytian nytian merged commit 71976c4 into main Oct 16, 2023
2 checks passed
@nytian nytian deleted the nytian/removeSTJ branch October 16, 2023 19:06
nytian added a commit that referenced this pull request Oct 25, 2023
* remove STJ with Newtonsoft

* increase DTFx.AS version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants