Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correlation test fail except for external event with extended session #430

Merged
merged 7 commits into from
Nov 2, 2020
Merged

Fix: correlation test fail except for external event with extended session #430

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77013b6
fix correlation test fail except for external event with extended ses…
TsuyoshiUshio Aug 6, 2020
c3fcec4
Fix for External Event only Orchestration with Unit Test
TsuyoshiUshio Sep 15, 2020
b63ce9d
Remove trackingStore operation
TsuyoshiUshio Sep 23, 2020
18342b8
fix: wrong else line
TsuyoshiUshio Sep 23, 2020
11725f8
Set ExecutionStartedEvent.Correlation on the DurableTask.Core side.
TsuyoshiUshio Sep 25, 2020
ceb3419
Update src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
TsuyoshiUshio Sep 26, 2020
b3d6bea
Update src/DurableTask.AzureStorage/Tracking/AzureTableTrackingStore.cs
TsuyoshiUshio Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/DurableTask.Core/TaskHubClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,8 @@ async Task<OrchestrationInstance> InternalCreateOrchestrationInstanceWithRaisedE
};

this.logHelper.SchedulingOrchestration(startedEvent);

CorrelationTraceClient.Propagate(() => CreateAndTrackDependencyTelemetry(requestTraceContext));

// Raised events and create orchestration calls use different methods so get handled separately
await this.ServiceClient.CreateTaskOrchestrationAsync(startMessage, dedupeStatuses);
Expand All @@ -559,10 +561,10 @@ async Task<OrchestrationInstance> InternalCreateOrchestrationInstanceWithRaisedE
},
Event = eventRaisedEvent,
};

await this.ServiceClient.SendTaskOrchestrationMessageAsync(eventMessage);
}

CorrelationTraceClient.Propagate(() => CreateAndTrackDependencyTelemetry(requestTraceContext));

return orchestrationInstance;
}
Expand Down