Enabling Extended Session Distributed Tracing #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsuyoshiUshio
commented
Mar 2, 2020
| () => | ||
| { | ||
| // Check if it is extended session. | ||
| isExtendedSession = this.concurrentSessionLock.Acquire(); |
There was a problem hiding this comment.
@cgillum Is there a better way to check if it is an extended session?
I don't know why checking the lock availability becomes checking the extended session. It works, however, not cool.
There was a problem hiding this comment.
There might be... I will get back to you on that.
| () => | ||
| { | ||
| // Check if it is extended session. | ||
| isExtendedSession = this.concurrentSessionLock.Acquire(); |
There was a problem hiding this comment.
There might be... I will get back to you on that.
TsuyoshiUshio
added a commit
to TsuyoshiUshio/durabletask
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that current implementation doesn't work well for extended session settings.
This PR unlock the extended session with Distributed Tracing.
Could you have a look, @cgillum ?