Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DurableTask.ApplicationInsights and DurableTask.AzureStorage Version #1172

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

nytian
Copy link
Collaborator

@nytian nytian commented Oct 13, 2024

As titled.
DurableTask.ApplicationInsights v0.1.6 -> v2.0.0 as it uses DurableTask.Core v3.0.0.
DurableTask.AzureStorage v2.0.0- v2.0.1 for new changes in #1159

@nytian nytian marked this pull request as ready for review October 13, 2024 19:53
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good. However, I see that the "Build & Sign" pipeline failed with what looks like an ESRP authentication issue. However, this doesn't seem related to the code change, so I don't consider it a blocker for this PR.

@nytian
Copy link
Collaborator Author

nytian commented Oct 14, 2024

The code change looks good. However, I see that the "Build & Sign" pipeline failed with what looks like an ESRP authentication issue. However, this doesn't seem related to the code change, so I don't consider it a blocker for this PR.

Thanks for the review, Chris! The pipeline failed because I attempted to create the package for the bug bash using our old DevOps pipelines. Therefore, we don't need to worry about that failure. :)

@nytian nytian changed the title Update DurableTask.ApplicationInsights Version to v 0.2.0 Update DurableTask.ApplicationInsights and DurableTask.AzureStorage Version Oct 14, 2024
@nytian nytian merged commit 2795981 into main Oct 16, 2024
44 checks passed
@nytian nytian deleted the nytian/update_dtfx_application_insights_ver branch October 16, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants