Rev deps Microsoft.Extensions and System deps to 6.x #1143
Conversation
| @@ -47,7 +47,7 @@ | |||
| <PackageReference Include="Azure.Storage.Queues" Version="12.18.0" /> | |||
| <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" /> | |||
| <PackageReference Include="System.Linq.Async" Version="6.0.1" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" /> | |||
There was a problem hiding this comment.
This could even be outright removed and inherit the version from DurableTask.Core
There was a problem hiding this comment.
removed: 09d6a08
(looking into the test proj upgrade)
davidmrdavid
changed the title
| @@ -11,16 +11,21 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' != 'net462'"> | |||
| <PackageReference Include="Azure.Monitor.OpenTelemetry.Exporter" Version="1.0.0-beta.3" /> | |||
| <!-- Increasing Azure.Monitor.OpenTelemetry.Exporter to 1.0.0-beta.5 or beyond brings Systems.DiagnosticSource 7.x, which is uncompatible with netcoreapp3.1. | |||
There was a problem hiding this comment.
I recommend updating test projects to net6.0 anyways (separate PR?). netcoreapp3.1 is out of support
There was a problem hiding this comment.
Yeah that would be good. I would like to wait until bundles V4 is on net6.0, then perform the change. Currently this matches the bundles v4 TFM, which seems reasonable to me.
There was a problem hiding this comment.
@davidmrdavid bundles TFM only impacts nuget resolution. It has no impact on runtime. Runtime will be net6.0 not netcoreapp3.1 - so waiting for bundles to update to net6.0 is not relevant to this testing scenario.
There's a proposal to upgrade this deps as part of the DTFx.ASv2 / DTFx.Core v3 release. Just putting this out there to run the CI in advance. Let's not merge until we've had time to do an internal discussion