Convert timer target to UTC #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs
Outdated
Show resolved
Hide resolved
cgillum
reviewed
Jul 18, 2024
test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs
Outdated
Show resolved
Hide resolved
test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs
Outdated
Show resolved
Hide resolved
…ioTests.cs Co-authored-by: David Justo <[email protected]>
AnatoliB
force-pushed
the
anatolib/fix-issue-1127
branch
from
7437f94 to
1825acc
Compare
src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
Outdated
Show resolved
Hide resolved
src/DurableTask.AzureStorage/Tracking/AzureTableTrackingStore.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Justo <[email protected]>
Co-authored-by: David Justo <[email protected]>
This reverts commit 38c5b7a.
…OrchestrationAsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
The old Azure SDK (e.g. WindowsAzure.Storage v9.3.1) silently converts non-UTC datetime values to UTC before persisting them in a table. As a result, passing non-UTC datetime to
CreateTimerworked, even though this is not a recommended pattern.The new Azure SDK (e.g. Azure.Data.Tables v12.8.3) throws an exception on attempts to persist non-UTC datetime values, which causes a hard-to-diagnose issue later, after a successful
CreateTimerinvocation.This fix makes sure
CreateTimeralways converts the provided datetime value to UTC, to match the end-to-end behavior after the Azure SDK upgrade.Since this is a potentially breaking change to both DurableTask.Core and DurableTask.AzureStorage, it should be released only with DurableTask.Core v2 and DurableTask.AzureStorage v2.
2024-07-18 update: we decided to limit this fix to DurableTask.AzureStorage only, so no impact to DurableTask.Core