Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validate-build.yml to run DT.AS unit tests and change default value of UseTablePartitionManagement to true #1133

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update validate-build.yml to run DT.AS unit tests and change default value of UseTablePartitionManagement to true #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be7b51
Update AzureStorageOrchestrationServiceSettings.cs
bachuv Jul 11, 2024
44b23d8
Update validate-build.yml
bachuv Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/validate-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
- name: Test DTFx.Core
run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/DurableTask.Core.Tests/DurableTask.Core.Tests.csproj #--configuration $config --no-build --verbosity normal

# Azure Storage is commented out until DTFx.AS v2 is enabled, where Azurite can be used to run unit tests
# - name: Test DTFx.AzureStorage
# run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/DurableTask.AzureStorage.Tests/DurableTask.AzureStorage.Tests.csproj #--configuration $config --no-build --verbosity normal
- name: Test DTFx.AzureStorage
run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/DurableTask.AzureStorage.Tests/DurableTask.AzureStorage.Tests.csproj #--configuration $config --no-build --verbosity normal

2 changes: 1 addition & 1 deletion src/DurableTask.AzureStorage/AzureStorageOrchestrationServiceSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public class AzureStorageOrchestrationServiceSettings
/// <summary>
/// Use the newer Azure Tables-based partition manager instead of the older Azure Blobs-based partition manager. The default value is <c>false</c>.
/// </summary>
public bool UseTablePartitionManagement { get; set; } = false;
public bool UseTablePartitionManagement { get; set; } = true;

/// <summary>
/// User serialization that will respect <see cref="IExtensibleDataObject"/>. Default is false.
Expand Down