Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where input is not passed along when signaling an entity #1016

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sebastianburckhardt
Copy link
Collaborator

As reported in Azure/azure-functions-durable-extension#2690, the TaskEntityDispatcher contains a bug where the input field is lost when creating a entity request message representing a signal.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test update we could do to help confirm that this code path is working?

@thomaseyde
Copy link

When can we expect an updated NuGet package?

@lilyjma lilyjma merged commit 0dff764 into main Jan 24, 2024
2 checks passed
@lilyjma lilyjma deleted the sburckha/fix-missing-entity-input branch January 24, 2024 22:18
@davidmrdavid
Copy link
Collaborator

Should be coming up in the next release, or the one after that (there's a release in progress, not sure it it'll pick this up), as it's just been merged!

@thomaseyde
Copy link

Fix is not included in https://www.nuget.org/packages/Microsoft.Azure.Functions.Worker.Extensions.DurableTask/1.1.1

Is there a different NuGet package I should reference?

@Twiddeldum
Copy link

We have the same issue and we are waiting for nuget package containing the fix too.

@davidmrdavid
Copy link
Collaborator

@thomaseyde, @Twiddeldum: seems a corresponding Microsoft.Azure.Worker.Extension.DurableTask package with this fix was not released. My apologies for the delay. We're starting another release of our packages this week, and the aformentioned package is in scope, so I expect it should be released with it. ETA: 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants