az cli client cleanup #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidgamero
commented
Nov 22, 2024
•
davidgamero
commented
- move az cli methods to within the azClient
- consume CommandRunner for az cli
- update Ensure/Validation for AzCLI to methods that return errors so we can consume and test them directly via fakeCommandRunners
- revert contributor role to allow acr build and push for github action
davidgamero
commented
Nov 22, 2024
| @@ -34,7 +34,6 @@ application and service principle, and will configure that application to trust | |||
| ctx := cmd.Context() | |||
|
|
|||
| gh := providers.NewGhClient() | |||
| providers.EnsureAzCli() | |||
There was a problem hiding this comment.
moved this to inside the az client constructor
davidgamero
commented
Nov 22, 2024
| var _ CommandRunner = &DefaultCommandRunner{} | ||
|
|
||
| func (d *DefaultCommandRunner) RunCommand(args ...string) (string, error) { | ||
| log.Debug("Running command: ", args) |
There was a problem hiding this comment.
add debug log here to allow tracing command executions while debugging
davidgamero
commented
Nov 23, 2024
| @@ -10,10 +10,6 @@ deployVariables: | |||
| value: "testapp" | |||
| - name: "IMAGENAME" | |||
There was a problem hiding this comment.
we should rework the integration test generation to no longer be a big bash script and maybe leverage go natively. then we can integrate better defaults per-language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.