Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDK calls for createAzApp #276

Closed
wants to merge 10 commits into from

Conversation

Vidya2606
Copy link
Contributor

Description

Migrating the createAzApp funtion from Az CLI to Az SDK

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pkg/providers/azure.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
type GraphClient interface {
GetApplicationObjectId(ctx context.Context, appId string) (string, error)
Applications() *graphapp.ApplicationsRequestBuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we talked about creating an interface out of the ApplicationRequestBuilder so that we could mock the Post and other calls, are you still working through that or did you decide against it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried creating an interface, but the way is it used in other functions, I felt like it may not be a good idea. I can explain in more detail.

@Vidya2606 Vidya2606 closed this Jun 3, 2024
@Vidya2606
Copy link
Contributor Author

The migration requires registration to Graph App which means the user had to do a device code login in the web browser which seemed to be a bad user experience, so we decided to keep the functions as is.

@Vidya2606 Vidya2606 deleted the createAzApp_AzSDK branch June 3, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants