-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SDK calls for createAzApp #276
Conversation
type GraphClient interface { | ||
GetApplicationObjectId(ctx context.Context, appId string) (string, error) | ||
Applications() *graphapp.ApplicationsRequestBuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we talked about creating an interface out of the ApplicationRequestBuilder
so that we could mock the Post
and other calls, are you still working through that or did you decide against it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried creating an interface, but the way is it used in other functions, I felt like it may not be a good idea. I can explain in more detail.
The migration requires registration to Graph App which means the user had to do a device code login in the web browser which seemed to be a bad user experience, so we decided to keep the functions as is. |
Description
Migrating the createAzApp funtion from Az CLI to Az SDK
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: