Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh #267

Closed
wants to merge 5 commits into from
Closed

Update install.sh #267

wants to merge 5 commits into from

Conversation

sagarhm
Copy link

@sagarhm sagarhm commented Apr 18, 2024

This commit introduces a new installation script that automates the setup process for our project by using cURL to download and execute the script directly from GitHub.

Key Changes:

Issues Addressed:

  • Fixed an issue where the script would fail silently if JQ was not installed. Now, it prompts the user to install JQ if not found.
  • Improved error messaging to guide users more clearly through the necessary steps if JQ is missing.

Post-installation, the script might use an additional 1087 kB of disk space. Users are prompted to continue with the installation, ensuring they are aware of the space requirement.

  • Users experiencing a 'command not found' error for JQ should perform 'apt update' followed by 'apt install jq' to resolve the issue.

This update ensures users have a smoother initial setup experience and reduces manual intervention requirements.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sagarhm and others added 5 commits April 18, 2024 22:59
This commit introduces a new installation script that automates the setup process for our project by using cURL to download and execute the script directly from GitHub.

Key Changes:
- The script is accessed via: curl -fsSL https://raw.githubusercontent.com/Azure/draft/main/scripts/install.sh | bash
- It includes a preliminary check for the JQ processor, essential for the script's operation.

Issues Addressed:
- Fixed an issue where the script would fail silently if JQ was not installed. Now, it prompts the user to install JQ if not found.
- Improved error messaging to guide users more clearly through the necessary steps if JQ is missing.

Post-installation, the script might use an additional 1087 kB of disk space. Users are prompted to continue with the installation, ensuring they are aware of the space requirement.


- Users experiencing a 'command not found' error for JQ should perform 'apt update' followed by 'apt install jq' to resolve the issue.

This update ensures users have a smoother initial setup experience and reduces manual intervention requirements.
@gambtho gambtho closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants