Rehauling Directories, Path Logic, and Test Logic to Conform to Automated Payload (/lib) #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l get from rustam's automation. Lot of things renamed to better conform to actual behavior. TestManifests now have an array of paths for success and error cases, so there can be 1 to N success/error cases per constraint/template. Added semantic version sorting for grabbing the latest constraint/templates available.
NickKeller
reviewed
Feb 13, 2024
| // methods for retrieval of deployment manifest, constraint templates, and constraints | ||
| func (fc FileCrawler) ReadDeployment(path string) (*unstructured.Unstructured, error) { | ||
| // sorts the list of supported safeguards versions and returns the last item in the list | ||
| func getLatestSafeguardsVersion() string { |
There was a problem hiding this comment.
Fine for now, but in the future we should allow the user to specify the version
NickKeller
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: