Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

[feature] Support for NSG naming, extended fields, and update to address-prefixes #44

Closed
arnaudlh opened this issue Jun 15, 2020 · 0 comments · Fixed by #49
Closed

[feature] Support for NSG naming, extended fields, and update to address-prefixes #44

arnaudlh opened this issue Jun 15, 2020 · 0 comments · Fixed by #49
Labels
enhancement New feature or request landingzone_hub_spoke Related to landingzone_hub_spoke landingzone_secure_vnet_dmz Related to landingzone_secure_vnet_dmz landingzone_vdc_demo Related to landingzone_vdc_demo
Milestone

Comments

@arnaudlh
Copy link
Member

arnaudlh commented Jun 15, 2020

Modernize support for Virtual Network to support module 3.0.0 to support:

  • removing the address-prefix deprecation warning to support address-prefixes instead
  • NSG name
  • extended NSG fields
@arnaudlh arnaudlh added enhancement New feature or request landingzone_hub_spoke Related to landingzone_hub_spoke landingzone_secure_vnet_dmz Related to landingzone_secure_vnet_dmz landingzone_vdc_demo Related to landingzone_vdc_demo labels Jun 15, 2020
@arnaudlh arnaudlh added this to the 2006 milestone Jun 15, 2020
@arnaudlh arnaudlh changed the title [feature] Support for NSG naming [feature] Support for NSG naming, extended fields, and update to address-prefixes Jun 15, 2020
@arnaudlh arnaudlh linked a pull request Jul 1, 2020 that will close this issue
@arnaudlh arnaudlh mentioned this issue Jul 1, 2020
LaurentLesle added a commit that referenced this issue Jul 2, 2020
* Change ci name

* Modern activity logs #39

* Housekeeping and versioning update

* Updating foundations CI + formatting

* Support for NSG naming, extended fields, and update to address-prefixes #44

* azurerm 2.15

* Update config for CI

* Add VSCodespace

* Documentation update

* Changelog

* Latest log_analytics

* Updating readme, adding documentation and adding devcontainer settings.

* Remove workspace

* Rename devcontainer

* launchpad light 2006

* Add support for environment

* Add environment and update tags

* Backward support for environment

* Introducing Azure Virtual WAN landing zones (#48)

* Initial commit hub_mesh

* Update readme

* Fix output

* Addind explicit dependency for fw rg

* Secured vhub by default for CI

* Update ci-vnext with launchpad light

* Update path

* Add tf/caf/ mapping

* Update vnext

* Fix logged_in user

* Fix destroy vnext CI

* Fix environment attribute in ci

* pickup environment from launchpad

* Add ci job id as prefix

* Remove workspace tags

* Fix prefix in ci

* Add support to overwride prefix in caf foundations

* Update prefix startwith alphe for keyvault

* Update documentation

* Update formating of files

* Adding a g in prefix for ci to avoid errors
with event hub or keyvault

* ci-vnext: remove prefix in LZ as coming
from foundation

* ci-vnext - remove prefix on lz destroy

* Fix testing-job-id typo

* ci var should be testing_job_id for jmespath

* Update module conventions documentation

* Including rover release

* landingzones vnext

* Update CI for master

* Add breaking changes and depreceated section

* Update doc for VSCodespace and CI to exclude docs

Co-authored-by: lolorol <[email protected]>
Co-authored-by: lolorol <[email protected]>
LaurentLesle added a commit that referenced this issue Jul 24, 2020
* Change ci name

* Modern activity logs #39

* Housekeeping and versioning update

* Updating foundations CI + formatting

* Support for NSG naming, extended fields, and update to address-prefixes #44

* azurerm 2.15

* Update config for CI

* Add VSCodespace

* Documentation update

* Changelog

* Latest log_analytics

* Updating readme, adding documentation and adding devcontainer settings.

* Remove workspace

* Rename devcontainer

* launchpad light 2006

* Add support for environment

* Add environment and update tags

* Backward support for environment

* Introducing Azure Virtual WAN landing zones (#48)

* Initial commit hub_mesh

* Update readme

* Fix output

* Addind explicit dependency for fw rg

* Secured vhub by default for CI

* Update ci-vnext with launchpad light

* Update path

* Add tf/caf/ mapping

* Update vnext

* Fix logged_in user

* Fix destroy vnext CI

* Fix environment attribute in ci

* pickup environment from launchpad

* Add ci job id as prefix

* Remove workspace tags

* Fix prefix in ci

* Add support to overwride prefix in caf foundations

* Update prefix startwith alphe for keyvault

* Update documentation

* Update formating of files

* Adding a g in prefix for ci to avoid errors
with event hub or keyvault

* ci-vnext: remove prefix in LZ as coming
from foundation

* ci-vnext - remove prefix on lz destroy

* Fix testing-job-id typo

* ci var should be testing_job_id for jmespath

* Update module conventions documentation

* Including rover release

* landingzones vnext

* Update CI for master

* Add breaking changes and depreceated section

* Update doc for VSCodespace and CI to exclude docs

* azure devops - add keyvault secret placeholder for
management pat

* Add azure devops add-on

* Add pat token in keyvault secrets

* addon - azure devops - adding variable groups

* add-on - azure devops - fix a condition when
there are no variable groups to create

* addon azdo - add azure pipelines

* add-on: azure devops  self-hosted agent

* Updating launchapd

* Adding azuredevops_resource_authorization

* Fix regression - launchpad - add networking
default settings

* Update launchpad prefix to null by default to
generate random prefix

* Cleanup output

* Update prefix logic

* move launchpad_light default settings to tfvars

* Update gitignore

* Add comments

* Adjust ci to new variables

* Adjust ci to launchpad variables

* Adjust syntax of object in command file

* Adding convention in CI jobs

* Updating convention in CI

* Adjusting the ci command

* Move to simpler structure

* Fix parameters

* Adjust variables

* fix local variables

* Remove variables set by rover at runtime

* Update CI branch to rover vnext commands

* Initial documentaiton of variables

* Update rover for vnext

* Remove global_settings from variable file

* Updating the output resource_groups

* Updating docs for new rover instructions

* Update to stable rover

* Update CI

* Add debug

* Update README.md

Co-authored-by: lolorol <[email protected]>
Co-authored-by: Arnaud Lheureux <[email protected]>
Co-authored-by: Arnaud Lheureux <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request landingzone_hub_spoke Related to landingzone_hub_spoke landingzone_secure_vnet_dmz Related to landingzone_secure_vnet_dmz landingzone_vdc_demo Related to landingzone_vdc_demo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant