Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Incorrect command in demo #3

Closed
brk3 opened this issue Nov 9, 2020 · 1 comment · Fixed by #4
Closed

Incorrect command in demo #3

brk3 opened this issue Nov 9, 2020 · 1 comment · Fixed by #4
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@brk3
Copy link

brk3 commented Nov 9, 2020

When using command provided in https://github.com/Azure/caf-terraform-landingzones-starter/blob/starter/configuration/demo/README.md for deploying the launchpad (1. Launchpad-level0 landing zones -> Deploy the launchpad), I get the following:

$ export environment=demo
$ rover -lz /tf/caf/public/landingzones/caf_launchpad \
  -var-folder /tf/caf/configuration/${environment}/level0 \
  -parallelism 30 \
  -level level0 \
  -env ${environment} \
  -launchpad \
  -a plan
...
var.dynamic_keyvault_secrets
  Enter a value:

In order to make it correctly I changed the value of -var-folder in the above to /tf/caf/configuration/${environment}/level0/launchpad so it could correctly find the vars.

Seems like an easy fix but I'm new to rover and the structure of this project so opted to submit this issue instead for anyone else that may come across this.

@arnaudlh arnaudlh self-assigned this Nov 10, 2020
@arnaudlh arnaudlh added the documentation Improvements or additions to documentation label Nov 10, 2020
@arnaudlh
Copy link
Member

thanks @brk3 - will fix - don't hesitate to submit a PR :)

arnaudlh pushed a commit that referenced this issue Nov 10, 2020
@arnaudlh arnaudlh mentioned this issue Nov 10, 2020
8 tasks
@arnaudlh arnaudlh linked a pull request Nov 10, 2020 that will close this issue
8 tasks
arnaudlh added a commit that referenced this issue Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants