Add test for @include over @internal #371
Conversation
🦋 Changeset detectedLatest commit: 137e950 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tadelesh
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
timotheeguerin and
tjprescott
as code owners
packages/cadl-ranch-specs/http/azure/client-generator-core/internal/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/azure/client-generator-core/internal/main.tsp
Outdated
Show resolved
Hide resolved
| @doc("This is a model only used by internal operation. Also, it is decorated with @include. It should be generated and exported.") | ||
| @global.Azure.ClientGenerator.Core.include | ||
| model InternaIncludelModel { | ||
| name: string; |
There was a problem hiding this comment.
Should we add a nested model to also test transitivity?
Or, if we are not sure how transitivity works for @include, I am fine to leave as this.
There was a problem hiding this comment.
I think transitivity should be the work of isInclude (though it seems current TCGC has not implemented it yet). I've created an issue to track.
There was a problem hiding this comment.
I think we should figure out this issue now.
Added nested model in current test, and a fix for @include transitivity: https://github.com/Azure/typespec-azure/pull/3267. |
Cadl Ranch Contribution Checklist:
@scenarionames. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDocs for extra scenario description and to tell people how to pass my mock api check.This test is from openai real use case: Azure/autorest.csharp#3519. The new added test could not be tested by mock server, different languages' SDK should add test for their generated code.
The logic emitter should accomplish:
isInternalwill returntrueforInternaIncludelModelmodelisIncludewill returntrueforInternaIncludelModelmodelInternaIncludelModelwill be included ingetAllModelsInternaIncludelModeland make it public to user.