Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic limits for # of params, outputs, vars and resources #5638

Merged
merged 17 commits into from
Feb 1, 2022

Conversation

sammeel
Copy link
Contributor

@sammeel sammeel commented Jan 16, 2022

Fixes #1453

I wasn't sure if you liked the large datarows of the tests or if you'd prefer some loops to generate it within the test. I have sticked with the current more verbose output as this matches other unit tests.
Let me know if you want me to change it.

I still have to create the doc pages. I'll mention it here when done.

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing to documentation

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@ghost
Copy link

ghost commented Jan 16, 2022

CLA assistant check
All CLA requirements met.

@stan-sz
Copy link
Contributor

stan-sz commented Jan 17, 2022

Great change! Additionally with #5626 merged in, @anthony-c-martin, is there a limit on imports?
Also, is there a limit on metadata?

@StephenWeatherford StephenWeatherford self-requested a review January 20, 2022 22:34
@anthony-c-martin
Copy link
Member

Great change! Additionally with #5626 merged in, @anthony-c-martin, is there a limit on imports? Also, is there a limit on metadata?

Good question. There's no limit on imports, and I'm not aware of any limit on metadata.

@sammeel
Copy link
Contributor Author

sammeel commented Feb 1, 2022

I'm not sure if the failing build is something I can fix. If so, could anyone assist in fixing it.
image

public MaxNumberOutputsRule() : base(
code: Code,
description: CoreResources.MaxNumberOutputsRuleDescription,
docUri: new Uri($"https://aka.ms/bicep/linter/{Code}"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{Code}

Would you be able to write up a small doc for each new rule? The docs should go into the /docs/linter-rules/ directory. You can use the deleted files in #5590 as an example of the format. I think we can skip the example part on these rules because they will be super verbose, though.

Once the PR is merged, I can create the aka.ms links for the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will do. I'll add the same content as I did for the azure docs PR: https://github.com/MicrosoftDocs/azure-docs/pull/86489/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait! I didn't realize you had a docs PR out. Docs is all we need 🙂.

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@majastrz majastrz merged commit 3503c68 into Azure:main Feb 1, 2022
@sammeel sammeel deleted the sammeel/limits branch February 1, 2022 20:11
@StephenWeatherford StephenWeatherford added devdiv Related to Bicep tooling efforts in DevDiv story: linter rules labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devdiv Related to Bicep tooling efforts in DevDiv story: linter rules
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Warn about template limits
6 participants