-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic limits for # of params, outputs, vars and resources #5638
Conversation
Great change! Additionally with #5626 merged in, @anthony-c-martin, is there a limit on |
Good question. There's no limit on |
src/Bicep.Core/Analyzers/Linter/Rules/MaxNumberVariablesRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/MaxNumberResourcesRule.cs
Outdated
Show resolved
Hide resolved
public MaxNumberOutputsRule() : base( | ||
code: Code, | ||
description: CoreResources.MaxNumberOutputsRuleDescription, | ||
docUri: new Uri($"https://aka.ms/bicep/linter/{Code}"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to write up a small doc for each new rule? The docs should go into the /docs/linter-rules/
directory. You can use the deleted files in #5590 as an example of the format. I think we can skip the example part on these rules because they will be super verbose, though.
Once the PR is merged, I can create the aka.ms links for the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will do. I'll add the same content as I did for the azure docs PR: https://github.com/MicrosoftDocs/azure-docs/pull/86489/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait! I didn't realize you had a docs PR out. Docs is all we need 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Fixes #1453
I wasn't sure if you liked the large datarows of the tests or if you'd prefer some loops to generate it within the test. I have sticked with the current more verbose output as this matches other unit tests.
Let me know if you want me to change it.
I still have to create the doc pages. I'll mention it here when done.
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing to documentation
Contributing a feature