Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up some experimental features #14944

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Tidy up some experimental features #14944

merged 3 commits into from
Aug 30, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 30, 2024

  1. Remove 'extensionRegistry' experimental feature.
  2. Remove 'dynamicTypeLoading' experimental feature - instead of being based on the registry path ending in "/az", activate based on the name supplied in the extension configuration ("AzureResourceManager").
  3. Remove the "extension alias" bicepconfig capability to avoid exposing it - it's not fully implemented, and needs more design work.
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Test this change out locally with the following install scripts (Action run 10637134995)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10637134995
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10637134995"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10637134995
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10637134995"

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   25m 22s ⏱️ - 8m 0s
11 042 tests  -     28  11 042 ✅  -     28  0 💤 ±0  0 ❌ ±0 
25 860 runs   - 12 950  25 860 ✅  - 12 950  0 💤 ±0  0 ❌ ±0 

Results for commit 40d70c0. ± Comparison against base commit 0aa6523.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Ant/extensions Tidy up some experimental features Aug 30, 2024
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit d5079a7 into main Aug 30, 2024
51 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/extensions branch August 30, 2024 18:02
lakshmimsft pushed a commit to radius-project/radius that referenced this pull request Oct 23, 2024
# Description

Some experimental features in the bicepconfig were consolidated in the
Bicep repo: Azure/bicep#14944. This PR removes
the unnecessary features.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

## Contributor checklist
Please verify that the PR meets the following requirements, where
applicable:

- [ ] An overview of proposed schema changes is included in a linked
GitHub issue.
- [ ] A design document PR is created in the [design-notes
repository](https://github.com/radius-project/design-notes/), if new
APIs are being introduced.
- [ ] If applicable, design document has been reviewed and approved by
Radius maintainers/approvers.
- [x] A PR for the [samples
repository](https://github.com/radius-project/samples) is created, if
existing samples are affected by the changes in this PR. PR:
radius-project/samples#1879
- [x] A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made. PR: radius-project/docs#1265
- [x] A PR for the [recipes
repository](https://github.com/radius-project/recipes) is created, if
existing recipes are affected by the changes in this PR. PR:
radius-project/recipes#80

Signed-off-by: sk593 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate extensibility related experimental feature flags
2 participants