-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic loading feature to load providers from custom bicepconfig.json aliases #12267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this change out locally with the following install scripts (Action run 6869198300) VSCode
Azure CLI
|
src/Bicep.Core/Semantics/Namespaces/ResourceTypesProviderDescriptor.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Semantics/Namespaces/ResourceTypesProviderDescriptor.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Semantics/Namespaces/DefaultNamespaceProvider.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Semantics/Namespaces/DefaultNamespaceProvider.cs
Outdated
Show resolved
Hide resolved
remode default parameter values allow nullable paths
jeskew
reviewed
Nov 13, 2023
shenglol
reviewed
Nov 13, 2023
shenglol
reviewed
Nov 13, 2023
shenglol
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
story: dynamic type loading
Collects all work items related to decoupling of Bicep types from compiler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
bicepconfig.json
aliasesResourceTypeProviderFactory
class that caches providers improving the compilation speedNamespaceType? TryGetNamespace()
to use a provider descriptor object reducing the number of arguments passed to it and improving readability and separation of concerns.builtin
version to distinguish between statically loadedaz
from dynamically loaded onesFixes
Microsoft Reviewers: Open in CodeFlow