Provider restore for resource type providers #11458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asilverman
changed the title
asilverman
force-pushed
the
asilverman/prototype/providerRestore
branch
from
2b76db4 to
cf3654f
Compare
asilverman
commented
Aug 8, 2023
asilverman
commented
Aug 8, 2023
asilverman
force-pushed
the
asilverman/prototype/providerRestore
branch
from
cf3654f to
3822fc8
Compare
asilverman
force-pushed
the
asilverman/prototype/providerRestore
branch
from
3822fc8 to
445c903
Compare
asilverman
requested review from
shenglol,
majastrz,
anthony-c-martin and
jeskew
jeskew
reviewed
Aug 9, 2023
src/Bicep.Core.UnitTests/Modules/OciArtifactModuleReferenceTests.cs
Outdated
Show resolved
Hide resolved
majastrz
reviewed
Aug 10, 2023
majastrz
reviewed
Aug 10, 2023
majastrz
reviewed
Aug 10, 2023
majastrz
reviewed
Aug 10, 2023
majastrz
reviewed
Aug 10, 2023
shenglol
reviewed
Aug 11, 2023
shenglol
reviewed
Aug 11, 2023
shenglol
reviewed
Aug 11, 2023
added 4 commits
August 11, 2023 13:19
shenglol
reviewed
Aug 14, 2023
shenglol
reviewed
Aug 16, 2023
shenglol
reviewed
Aug 16, 2023
shenglol
approved these changes
Aug 16, 2023
asilverman
added a commit
that referenced
this pull request
Aug 22, 2023
…nifest` (#11591) ## Description Addresses [PR comment](#11458 (comment)) to use `System.Text.Json` instead of `Newtonsoft.Json` in the deserialization of `OciManifest` class ## Changes * Adds biz logic to support deserialization with `System.Text.Json` * Adds a unit test to verify proper deserialization of a valid JSON manifest ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/11591) --------- Co-authored-by: Ariel Silverman <[email protected]>
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables the restoration of provider artifacts from the bicep registry. In its current (temporary) form the provider artifact is disguised as a module given that the handling of OCI Artifacts by the ModuleRegistry is not decoupled from the handling of modules. Refactoring (in separate PRs) is needed to decouple the concerns and have a simpler handling of the provider artifacts.
Microsoft Reviewers: codeflow:open?pullrequest=#11458