Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove orphan out of databricks/workspace #940

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

clintgrove
Copy link
Contributor

@clintgrove clintgrove commented Feb 6, 2024

Description

removing orphan from readme

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

  • This is a bug fix:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.
  • I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:
    • The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
    • The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • The PR contains breaking changes, and I have bumped the MAJOR version in version.json.
  • I have updated the examples in README with the latest module version number.

@clintgrove clintgrove requested review from a team as code owners February 6, 2024 15:27
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Feb 6, 2024
@ChrisSidebotham ChrisSidebotham merged commit c428930 into Azure:main Feb 6, 2024
14 checks passed
@ChrisSidebotham ChrisSidebotham self-assigned this Feb 6, 2024
@ChrisSidebotham ChrisSidebotham added Bug Fix Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants