Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new module avm/res/synapse/workspace #914

Merged
merged 61 commits into from
Feb 15, 2024
Merged

feat: new module avm/res/synapse/workspace #914

merged 61 commits into from
Feb 15, 2024

Conversation

elanzel
Copy link
Contributor

@elanzel elanzel commented Feb 2, 2024

Description

New module migrated from CARML to AVM.

Related to module proposal Azure/Azure-Verified-Modules#575

Status badge:

avm.res.synapse.workspace

@elanzel elanzel requested review from a team as code owners February 2, 2024 11:52
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 2, 2024
@elanzel elanzel self-assigned this Feb 2, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Feb 9, 2024
@elanzel elanzel marked this pull request as draft February 12, 2024 08:05
@elanzel elanzel marked this pull request as ready for review February 13, 2024 16:16
@elanzel elanzel enabled auto-merge (squash) February 13, 2024 18:56
AlexanderSehr
AlexanderSehr requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for appling the 2 latest changes. 1 ask remains - which would be to refresh the readme with set updates. Aside from that I believe we're good to go :)

@elanzel
Copy link
Contributor Author

elanzel commented Feb 15, 2024

Thanks for appling the 2 latest changes. 1 ask remains - which would be to refresh the readme with set updates. Aside from that I believe we're good to go :)

Ops, i forgot it, sorry. Now it should be all ok, test action is green :-)

@elanzel elanzel merged commit 768cb8d into Azure:main Feb 15, 2024
9 checks passed
@matebarabas matebarabas mentioned this pull request Feb 16, 2024
Open
@elanzel elanzel deleted the synapse-workspace branch March 5, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@elanzel elanzel

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elanzel @AlexanderSehr @matebarabas @eriqua