Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/insights/private-link-scope #873

Merged
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
fac14a6
first commit
ahmadabdalla Dec 29, 2023
172d6ca
added conent
ahmadabdalla Dec 29, 2023
7b3f3ae
updates
ahmadabdalla Dec 29, 2023
f2d9a06
Updated it
ahmadabdalla Dec 29, 2023
136d358
updated after telemetry fix
ahmadabdalla Dec 30, 2023
0c27d9a
Updated Module
ahmadabdalla Jan 7, 2024
de21799
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Jan 7, 2024
928fd3b
Updated from Latest AVM Library
ahmadabdalla Jan 7, 2024
7768f34
update code owners
ahmadabdalla Jan 7, 2024
576ce93
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Jan 8, 2024
99df428
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Jan 8, 2024
94ce6d2
Merge remote-tracking branch 'origin/main' into users/ahmad/4413_priv…
ahmadabdalla Jan 16, 2024
dfff10e
updated pipeline
ahmadabdalla Jan 16, 2024
8cb733c
updated template
ahmadabdalla Jan 16, 2024
8e1d581
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Jan 17, 2024
9c508f3
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Jan 27, 2024
dffa544
updated to align with AVM
ahmadabdalla Jan 27, 2024
dd55ca5
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Jan 27, 2024
953f3fd
updated roles
ahmadabdalla Jan 27, 2024
8278b73
updated issue template
ahmadabdalla Jan 27, 2024
40919cf
Updated as per feedback
ahmadabdalla Jan 27, 2024
bb2e1d0
Updated WAF tests
ahmadabdalla Jan 28, 2024
a337728
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Feb 3, 2024
d18cdff
Update default access modes and remove custom DNS configurations
ahmadabdalla Feb 3, 2024
d2f7764
Refactor access mode settings in private link scope
ahmadabdalla Feb 4, 2024
3591dc6
Apply suggestions from code review
ahmadabdalla Feb 4, 2024
dc51df0
Merge remote-tracking branch 'upstream/main' into users/ahmad/4413_pr…
ahmadabdalla Feb 4, 2024
4b4c009
updated spacing on workflow file
ahmadabdalla Feb 5, 2024
fca592f
Merge branch 'main' into users/ahmad/4413_privateLinkScopes
eriqua Feb 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
/avm/res/insights/data-collection-rule/ @Azure/avm-res-insights-datacollectionrule-module-owners-bicep @Azure/avm-core-team-technical-bicep
/avm/res/insights/diagnostic-setting/ @Azure/avm-res-insights-diagnosticsetting-module-owners-bicep @Azure/avm-core-team-technical-bicep
/avm/res/insights/metric-alert/ @Azure/avm-res-insights-metricalert-module-owners-bicep @Azure/avm-core-team-technical-bicep
#/avm/res/insights/private-link-scope/ @Azure/avm-res-insights-privatelinkscope-module-owners-bicep @Azure/avm-core-team-technical-bicep
/avm/res/insights/private-link-scope/ @Azure/avm-res-insights-privatelinkscope-module-owners-bicep @Azure/avm-core-team-technical-bicep
AlexanderSehr marked this conversation as resolved.
Show resolved Hide resolved
/avm/res/insights/scheduled-query-rule/ @Azure/avm-res-insights-scheduledqueryrule-module-owners-bicep @Azure/avm-core-team-technical-bicep
/avm/res/insights/webtest/ @Azure/avm-res-insights-webtest-module-owners-bicep @Azure/avm-core-team-technical-bicep
/avm/res/key-vault/vault/ @Azure/avm-res-keyvault-vault-module-owners-bicep @Azure/avm-core-team-technical-bicep
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/avm_module_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ body:
- "avm/res/insights/data-collection-rule"
- "avm/res/insights/diagnostic-setting"
- "avm/res/insights/metric-alert"
# - "avm/res/insights/private-link-scope"
- "avm/res/insights/private-link-scope"
- "avm/res/insights/scheduled-query-rule"
- "avm/res/insights/webtest"
- "avm/res/key-vault/vault"
Expand Down
83 changes: 83 additions & 0 deletions .github/workflows/avm.res.insights.private-link-scope.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
name: "avm.res.insights.private-link-scope"

on:
schedule:
- cron: "0 12 1/15 * *" # Bi-Weekly Test (on 1st & 15th of month)
workflow_dispatch:
inputs:
staticValidation:
type: boolean
description: "Execute static validation"
required: false
default: true
deploymentValidation:
type: boolean
description: "Execute deployment validation"
required: false
default: true
removeDeployment:
type: boolean
description: "Remove deployed module"
required: false
default: true

ahmadabdalla marked this conversation as resolved.
Show resolved Hide resolved
push:
branches:
- main
paths:
- ".github/actions/templates/avm-**"
- ".github/workflows/avm.template.module.yml"
- ".github/workflows/avm.res.insights.private-link-scope.yml"
- "avm/res/insights/private-link-scope/**"
- "avm/utilities/pipelines/**"
- "!*/**/README.md"

env:
modulePath: "avm/res/insights/private-link-scope"
workflowPath: ".github/workflows/avm.res.insights.private-link-scope.yml"

concurrency:
group: ${{ github.workflow }}

jobs:
###########################
# Initialize pipeline #
###########################
job_initialize_pipeline:
runs-on: ubuntu-latest
name: "Initialize pipeline"
steps:
- name: "Checkout"
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: "Set input parameters to output variables"
id: get-workflow-param
uses: ./.github/actions/templates/avm-getWorkflowInput
with:
workflowPath: "${{ env.workflowPath}}"
- name: "Get module test file paths"
id: get-module-test-file-paths
uses: ./.github/actions/templates/avm-getModuleTestFiles
with:
modulePath: "${{ env.modulePath }}"
outputs:
workflowInput: ${{ steps.get-workflow-param.outputs.workflowInput }}
moduleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.moduleTestFilePaths }}
psRuleModuleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.psRuleModuleTestFilePaths }}
modulePath: "${{ env.modulePath }}"

##############################
# Call reusable workflow #
##############################
call-workflow-passing-data:
name: "Run"
ahmadabdalla marked this conversation as resolved.
Show resolved Hide resolved
needs:
- job_initialize_pipeline
uses: ./.github/workflows/avm.template.module.yml
with:
workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}"
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"
psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}"
modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}"
secrets: inherit
Loading
Loading