Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avm/res/databricks/workspace #792

Merged
merged 25 commits into from
Jan 19, 2024
Merged

feat: avm/res/databricks/workspace #792

merged 25 commits into from
Jan 19, 2024

Conversation

segraef
Copy link
Contributor

@segraef segraef commented Jan 12, 2024 •
edited
Loading

avm.res.databricks.workspace

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 12, 2024
@segraef segraef marked this pull request as ready for review January 12, 2024 07:46
@segraef segraef requested review from a team as code owners January 12, 2024 07:46
@segraef segraef enabled auto-merge (squash) January 12, 2024 07:50
@segraef segraef mentioned this pull request Jan 12, 2024
Closed
2 tasks
AlexanderSehr
AlexanderSehr requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires uncommenting in the /.github/CODEOWNERS file

@segraef
Copy link
Contributor Author

segraef commented Jan 12, 2024

Requires uncommenting in the /.github/CODEOWNERS file

done

@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 12, 2024
@segraef segraef requested a review from AlexanderSehr January 15, 2024 03:55
@segraef segraef requested a review from AlexanderSehr January 17, 2024 07:44
This was referenced Jan 17, 2024
Merged
Merged
Merged
AlexanderSehr
AlexanderSehr requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment •
edited by segraef
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side. The only items remaining:

  • Fix the conflicts in the CODEOWNERS file
  • Re-run the pipeline (the storage account name was ironically already taken)

@segraef
Copy link
Contributor Author

segraef commented Jan 19, 2024 •
edited
Loading

All good from my side. The only items remaining:

  • Fix the conflicts in the CODEOWNERS file
  • Re-run the pipeline (the storage account name was ironically already taken)

Have to change the prefix again, it's a managed storage account which gets created by the workspace but for some reason always pops up with the same error message although it's deleted properly.

@segraef segraef requested a review from AlexanderSehr January 19, 2024 06:05
@segraef segraef merged commit 194a626 into Azure:main Jan 19, 2024
9 checks passed
@segraef segraef deleted the databricks/workspace branch January 19, 2024 11:49
@segraef segraef mentioned this pull request Jan 22, 2024
Merged
10 tasks
@matebarabas matebarabas mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@segraef segraef

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@segraef @AlexanderSehr @matebarabas