-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/res/app/managed-environment #737
Merged
AlexanderSehr
merged 22 commits into
Azure:main
from
arnoldna:avm/res/app/managed-environment
Dec 21, 2023
Merged
feat: avm/res/app/managed-environment #737
AlexanderSehr
merged 22 commits into
Azure:main
from
arnoldna:avm/res/app/managed-environment
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
labels
Dec 20, 2023
avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml
Outdated
Show resolved
Hide resolved
avm/res/app/managed-environment/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is missing the update to the codeowners file (and group creation) if I'm not mistaken
avm/res/app/managed-environment/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
approved these changes
Dec 21, 2023
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated managed-environment to AVM