Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added matrix name to template increasing readability #727

Merged
merged 71 commits into from
Dec 19, 2023

Conversation

AlexanderSehr
Copy link
Contributor

Description

Added matrix name to template increasing readability

Before:
image

After:
image

@AlexanderSehr AlexanderSehr requested review from a team as code owners December 13, 2023 20:41
@AlexanderSehr AlexanderSehr self-assigned this Dec 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Dec 13, 2023
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 13, 2023
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 13, 2023 20:41
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement on readability, both for the compressed test case and replacing Module with Run.

The only update I'd challenge is the matrix header. Can we keep PSRule and Deploy instead of job_test_psrule and job_module_deploy?

@AlexanderSehr
Copy link
Contributor Author

Great improvement on readability, both for the compressed test case and replacing Module with Run.

The only udate I'd challenge is the matrix header. Can we keep PSRule and Deploy instead of job_test_psrule and job_module_deploy?

@eriqua Unfortunately not. The change was not intended and seems to be automatically done once you add a name to the matrix job. The name is then used for the jobs while the Id is used for the matrix header. I did not find a way to avoid this 😕

@eriqua
Copy link
Contributor

eriqua commented Dec 17, 2023

Great improvement on readability, both for the compressed test case and replacing Module with Run.
The only udate I'd challenge is the matrix header. Can we keep PSRule and Deploy instead of job_test_psrule and job_module_deploy?

@eriqua Unfortunately not. The change was not intended and seems to be automatically done once you add a name to the matrix job. The name is then used for the jobs while the

Heartbreaking

@AlexanderSehr AlexanderSehr requested a review from eriqua December 19, 2023 19:03
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit c685098 into Azure:main Dec 19, 2023
9 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/jobName branch December 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants