-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added matrix name to template increasing readability #727
feat: Added matrix name to template increasing readability #727
Conversation
…ts.ps1 Co-authored-by: Erika Gressi <[email protected]>
…ts.ps1 Co-authored-by: Erika Gressi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement on readability, both for the compressed test case and replacing Module
with Run
.
The only update I'd challenge is the matrix header. Can we keep PSRule
and Deploy
instead of job_test_psrule
and job_module_deploy
?
@eriqua Unfortunately not. The change was not intended and seems to be automatically done once you add a name to the matrix job. The name is then used for the jobs while the Id is used for the matrix header. I did not find a way to avoid this 😕 |
Heartbreaking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
Description
Added matrix name to template increasing readability
Before:
After: