Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Module avm/res/api-management/service #713

Merged
merged 43 commits into from
Dec 13, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Dec 9, 2023

Description

New Module avm/res/api-management/service, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.api-management.service

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 9, 2023
@krbar krbar self-assigned this Dec 9, 2023
@krbar krbar marked this pull request as ready for review December 10, 2023 15:27
@krbar krbar requested review from a team as code owners December 10, 2023 15:27
@BernieWhite
Copy link

@AlexanderSehr Agreed, seems fine. Although we just fixed a dependency issue in the latest prerelease. So you could try that. Happy to have a look at it though.

@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 11, 2023
@krbar
Copy link
Contributor Author

krbar commented Dec 13, 2023

@AlexanderSehr I think the module's issues are sorted out, please have a look if we can merge the module or if still some updated are required. Thanks!

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr I think the module's issues are sorted out, please have a look if we can merge the module or if still some updated are required. Thanks!

Just one comment left to get convinced on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants