Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Module avm/res/network/public-ip-prefix #690

Merged
merged 11 commits into from
Dec 3, 2023
Merged

feat: New Module avm/res/network/public-ip-prefix #690

merged 11 commits into from
Dec 3, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Dec 2, 2023

Description

New Module avm/res/network/public-ip-prefix, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.network.public-ip-prefix

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 2, 2023
@krbar krbar self-assigned this Dec 2, 2023
@krbar krbar marked this pull request as ready for review December 2, 2023 00:39
@krbar krbar requested review from a team as code owners December 2, 2023 00:39
@krbar krbar mentioned this pull request Dec 2, 2023
Closed
2 tasks
@matebarabas
Copy link
Contributor

@krbar, please don't forget to uncomment the related entry in CODEOWNERS file as part of this PR. Thanks!

AlexanderSehr
AlexanderSehr requested changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The readme generation was updated in main

@AlexanderSehr AlexanderSehr merged commit a74e36a into Azure:main Dec 3, 2023
9 checks passed
@krbar krbar deleted the users/krbar/pippfxModule branch December 3, 2023 22:15
@krbar krbar mentioned this pull request Dec 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@krbar krbar

Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krbar @matebarabas @AlexanderSehr