Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter PSRule validation on required test files #684

Merged
merged 49 commits into from
Nov 30, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Nov 30, 2023

Description

  • Filter PSRule validation only on defaults and waf-aligned test files
  • Added filter as action input regex default value
  • Updated job names for more readability

image

Pipeline
avm.res.network.virtual-network
avm.res.network.private-endpoint
avm.res.event-grid.domain

@eriqua eriqua self-assigned this Nov 30, 2023
@eriqua eriqua requested review from a team as code owners November 30, 2023 01:57
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 30, 2023
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous & splendid

@AlexanderSehr AlexanderSehr self-requested a review November 30, 2023 10:17
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small one: A new module 'Resources/Deployment-Scipts' was merged and requires the same workflow update

AlexanderSehr and others added 4 commits November 30, 2023 11:18
@eriqua
Copy link
Contributor Author

eriqua commented Nov 30, 2023

Small one: A new module 'Resources/Deployment-Scipts' was merged and requires the same workflow update

Done and pretty

Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@AlexanderSehr AlexanderSehr merged commit 1ced523 into Azure:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants