Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Moved Get-BRMRepositoryName to SharedScripts #682

Merged
merged 49 commits into from
Nov 30, 2023
Merged

feat: Moved Get-BRMRepositoryName to SharedScripts #682

merged 49 commits into from
Nov 30, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 29, 2023 •
edited
Loading

Description

  • Moved Get-BRMRepositoryName to SharedScripts
  • Tested all 5 invocations to ensure the new paths are resolved correctly

AlexanderSehr and others added 30 commits November 7, 2023 22:23
@AlexanderSehr
Added skeleton
20ac8b7
@AlexanderSehr
Implemented first new tests
4939b4d
@AlexanderSehr
Changed to warning
4e1d86f
@AlexanderSehr
Expanded test verbosity & added additional tets
94fff0b
@AlexanderSehr
Finalized further tests
c18ce6b
@AlexanderSehr
Update to latest
a343694
@AlexanderSehr
Update to latest
3a6f0a2
@AlexanderSehr
Added module name + small fix
4ab6a5b
@AlexanderSehr
Fixed kvlt
9bb64bd
@AlexanderSehr
Small caching fix
68e2bd2
@AlexanderSehr
Small fix and enabled passthru of warnings to GH
1a013c2
@AlexanderSehr
More updates
1c2fc8a
@AlexanderSehr
Update to latest
d9c6dd5
@AlexanderSehr
Updated test names
dd0c343
@AlexanderSehr
JSON rollback
2ebd458
@AlexanderSehr
Updated regex
f6caf7e
@AlexanderSehr
Removed assertion
f56f66a
@AlexanderSehr
Update to latest
282b640
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
c025f52 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
405901a 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr
Merge branch 'main' into users/alsehr/testFileCompliance
904c82f
@AlexanderSehr
Rollback of unrelated changes
ef24d1f
@AlexanderSehr
Merge branch 'Azure:main' into main
9393aa1
@AlexanderSehr
Merge branch 'Azure:main' into main
cb39086
@AlexanderSehr
Merge branch 'Azure:main' into main
89eac40
@AlexanderSehr
Merge branch 'Azure:main' into main
712a673
@AlexanderSehr
Resolved conflict
55e095f
@AlexanderSehr
Update to latest
3121335
@AlexanderSehr
Merge branch 'Azure:main' into main
e9d736c
@AlexanderSehr
Merge branch 'Azure:main' into main
abfa1b9
AlexanderSehr and others added 19 commits November 16, 2023 17:26
@AlexanderSehr
Merge branch 'Azure:main' into main
c6707f6
@AlexanderSehr
Merge branch 'Azure:main' into main
246f9ba
@AlexanderSehr
Merge branch 'Azure:main' into main
6e9729d
@AlexanderSehr
Merge branch 'Azure:main' into main
26ea9f6
@AlexanderSehr
Merge branch 'Azure:main' into main
c2d183b
@AlexanderSehr
Merge branch 'Azure:main' into main
0c6650e
@AlexanderSehr
Merge branch 'Azure:main' into main
65094a5
@AlexanderSehr
Merge branch 'Azure:main' into main
968cd9a
@AlexanderSehr
Merge branch 'Azure:main' into main
3c9589b
@AlexanderSehr
Merge branch 'Azure:main' into main
eb34ddf
@AlexanderSehr
Added pipeline to main for testing
3d4f5c6
@AlexanderSehr
Merge branch 'Azure:main' into main
70154f3
@AlexanderSehr
Merge branch 'Azure:main' into main
18bd2ad
@AlexanderSehr
Merge branch 'Azure:main' into main
940b34f
@AlexanderSehr
Merge branch 'Azure:main' into main
fbb840f
@AlexanderSehr
Update to latest
969db5e
@AlexanderSehr
Merge branch 'Azure:main' into main
381e366
@AlexanderSehr
Merge branch 'main' into users/alsehr/moveNameFunction
3970786
@AlexanderSehr
Moved script
63f2097
@AlexanderSehr AlexanderSehr self-assigned this Nov 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 29, 2023
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue and removed Needs: Triage 🔍 Maintainers need to triage still labels Nov 29, 2023
@AlexanderSehr AlexanderSehr linked an issue Nov 29, 2023 that may be closed by this pull request
AVM - Move Get-BRMRepositoryName to SharedScripts for consistency #681
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 29, 2023 17:48
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 29, 2023 17:48
ChrisSidebotham
ChrisSidebotham reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

eriqua
eriqua approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 1180d89 into Azure:main Nov 30, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSidebotham ChrisSidebotham ChrisSidebotham left review comments

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVM - Move Get-BRMRepositoryName to SharedScripts for consistency
3 participants
@AlexanderSehr @ChrisSidebotham @eriqua