Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Diverse Bugfixes & improved module.test.ps1 efficiency #646

Merged
merged 75 commits into from
Nov 29, 2023
Merged

fix: Diverse Bugfixes & improved module.test.ps1 efficiency #646

merged 75 commits into from
Nov 29, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 17, 2023 •
edited
Loading

Description

  • Removed original caching solution and replaced it with a multi-threaded solution that compiles are required files once in the beginning
  • Removed redundant test file script (formerly required to support parameter.json files)
  • Fixed API tests
  • Fixed local test file paths

Runtime before change

  1. 14.4s
  2. 14.9s
  3. 15.9s

Runtime after change

  1. 10.7s
  2. 7.3s
  3. 7.4s
Pipeline
avm.res.key-vault.vault

AlexanderSehr and others added 30 commits November 7, 2023 22:23
@AlexanderSehr
Added skeleton
20ac8b7
@AlexanderSehr
Implemented first new tests
4939b4d
@AlexanderSehr
Changed to warning
4e1d86f
@AlexanderSehr
Expanded test verbosity & added additional tets
94fff0b
@AlexanderSehr
Finalized further tests
c18ce6b
@AlexanderSehr
Update to latest
a343694
@AlexanderSehr
Update to latest
3a6f0a2
@AlexanderSehr
Added module name + small fix
4ab6a5b
@AlexanderSehr
Fixed kvlt
9bb64bd
@AlexanderSehr
Small caching fix
68e2bd2
@AlexanderSehr
Small fix and enabled passthru of warnings to GH
1a013c2
@AlexanderSehr
More updates
1c2fc8a
@AlexanderSehr
Update to latest
d9c6dd5
@AlexanderSehr
Updated test names
dd0c343
@AlexanderSehr
JSON rollback
2ebd458
@AlexanderSehr
Updated regex
f6caf7e
@AlexanderSehr
Removed assertion
f56f66a
@AlexanderSehr
Update to latest
282b640
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
c025f52 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
405901a 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr
Merge branch 'main' into users/alsehr/testFileCompliance
904c82f
@AlexanderSehr
Rollback of unrelated changes
ef24d1f
@AlexanderSehr
Merge branch 'Azure:main' into main
9393aa1
@AlexanderSehr
Merge branch 'Azure:main' into main
cb39086
@AlexanderSehr
Merge branch 'Azure:main' into main
89eac40
@AlexanderSehr
Merge branch 'Azure:main' into main
712a673
@AlexanderSehr
Resolved conflict
55e095f
@AlexanderSehr
Update to latest
3121335
@AlexanderSehr
Merge branch 'Azure:main' into main
e9d736c
@AlexanderSehr
Merge branch 'Azure:main' into main
abfa1b9
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 27, 2023 22:49
@AlexanderSehr AlexanderSehr marked this pull request as draft November 29, 2023 07:56
auto-merge was automatically disabled November 29, 2023 07:56

Pull request was converted to draft

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 29, 2023 07:57
@AlexanderSehr AlexanderSehr requested a review from eriqua November 29, 2023 08:00
eriqua
eriqua previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr marked this pull request as draft November 29, 2023 12:15
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 29, 2023 12:15
@AlexanderSehr AlexanderSehr reopened this Nov 29, 2023
ChrisSidebotham
ChrisSidebotham approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@AlexanderSehr AlexanderSehr merged commit 1436704 into Azure:main Nov 29, 2023
13 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/testSpeedUp-20231117 branch November 29, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

@ChrisSidebotham ChrisSidebotham ChrisSidebotham approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Improve module.test.ps1 efficiency
3 participants
@AlexanderSehr @ChrisSidebotham @eriqua