Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added URL fetch error handling to test script #642

Merged
merged 36 commits into from
Nov 17, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 16, 2023

Description

Handling cases where the URL is wrong or invalid. Will write a warning and skip the check instead of throwing an exception

Depends on #613 as we should add the same to its telemetry check

Note: The 2 other locations that use external URLs already have error handling implemented

Pipeline
avm.res.key-vault.vault

@AlexanderSehr AlexanderSehr self-assigned this Nov 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 16, 2023
@AlexanderSehr AlexanderSehr added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 16, 2023
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 16, 2023 23:05
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 16, 2023 23:05
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 16, 2023 23:05
@AlexanderSehr AlexanderSehr merged commit 030b64d into Azure:main Nov 17, 2023
12 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/errorHandling branch November 17, 2023 14:58
segraef pushed a commit to segraef/bicep-registry-modules that referenced this pull request Nov 19, 2023
## Description

Handling cases where the URL is wrong or invalid. Will write a warning
and skip the check instead of throwing an exception

Depends on Azure#613 as we should add the same to its telemetry check


| Pipeline |
| - |

|[![avm.res.key-vault.vault](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=users%2Falsehr%2FerrorHandling&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml)
|

---------

Co-authored-by: Erika Gressi <[email protected]>
@matebarabas matebarabas removed the Needs: Triage 🔍 Maintainers need to triage still label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants