-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bicep Module for Bing Resource #407
Merged
dciborow
merged 23 commits into
Azure:main
from
tanujbhatia1708:fix/XMIXSRE-2718-bing-resource
Jul 4, 2023
Merged
feat: Bicep Module for Bing Resource #407
dciborow
merged 23 commits into
Azure:main
from
tanujbhatia1708:fix/XMIXSRE-2718-bing-resource
Jul 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujbhatia1708
changed the title
fix: Bicep Module for Bing Resource
feat: Bicep Module for Bing Resource
Jun 9, 2023
/azp run |
Commenter does not have sufficient privileges for PR 407 in repo Azure/bicep-registry-modules |
Bing Search is no longer part of Cognitive Services since October 2020. I wonder if we should use |
@shenglol i have updated the path . Thanks |
dciborow
approved these changes
Jul 4, 2023
dciborow
reviewed
Jul 4, 2023
dciborow
reviewed
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.
Enable GitHub Worksflows in your fork to enable auto-generation of assets with our GitHub Action.
To trigger GitHub Actions after auto-generation, add a GitHub PAT as a secret in your forked repository called
PAT
.Adding a new module
brm validate
locally to verify the module files.Updating an existing module
brm validate
locally to verify the module files.version.json
file properly:version.json
.version.json
.version.json
.