Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bicep Module for Bing Resource #407

Merged
merged 23 commits into from
Jul 4, 2023

Conversation

tanujbhatia1708
Copy link
Contributor

@tanujbhatia1708 tanujbhatia1708 commented Jun 9, 2023

Description

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.

Enable GitHub Worksflows in your fork to enable auto-generation of assets with our GitHub Action.
To trigger GitHub Actions after auto-generation, add a GitHub PAT as a secret in your forked repository called PAT.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

  • This is a bug fix:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.
  • I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:
    • The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
    • The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • The PR contains breaking changes, and I have bumped the MAJOR version in version.json.
  • I have updated the examples in README with the latest module version number.

@tanujbhatia1708 tanujbhatia1708 changed the title fix: Bicep Module for Bing Resource feat: Bicep Module for Bing Resource Jun 9, 2023
@tanujbhatia1708
Copy link
Contributor Author

tanujbhatia1708 commented Jun 9, 2023

@dciborow @shenglol @Gordonby Can we please register the subscription for Microsoft.Bing ? Also Please help to review

@tanujbhatia1708
Copy link
Contributor Author

@dciborow @shenglol Please help to review

@tanujbhatia1708
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 407 in repo Azure/bicep-registry-modules

@shenglol
Copy link
Contributor

shenglol commented Jul 3, 2023

Bing Search is no longer part of Cognitive Services since October 2020. I wonder if we should use ai/bing-search as the module path.

@tanujbhatia1708
Copy link
Contributor Author

@shenglol i have updated the path . Thanks

@dciborow dciborow enabled auto-merge (squash) July 4, 2023 18:59
@dciborow dciborow merged commit 7768140 into Azure:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants