-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add publicNetworkAccess param and update firewall rule logic #3959
Conversation
…Updated network configs to support publicNetworkAccess and updated max and private tests
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
avm/res/db-for-my-sql/flexible-server/advanced-threat-protection/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/db-for-my-sql/flexible-server/tests/e2e/max/main.test.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off we go (again). Thanks @hundredacres. Great work 💪
Description
Add publicNetworkAccess param and update firewall rule logic. Also added support for Defender for Cloud, a WAF requirement.
Fixes #3717
Closes #3717
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.