Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regenerate readmes failing on static validation due to wrong links #3712

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Nov 1, 2024

Description

Regenerate readmes missing correct link to Azure Resource Reference documentation

Pipeline Reference

Pipeline
avm.ptn.azd.apim-api
avm.ptn.network.hub-networking
avm.res.dev-ops-infrastructure.pool
avm.res.network.azure-firewall
avm.res.network.front-door-web-application-firewall-policy
avm.res.network.virtual-hub
avm.res.web.hosting-environment
avm.res.web.site
avm.res.web.static-site

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 1, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 1, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@eriqua eriqua enabled auto-merge (squash) November 1, 2024 18:31
@eriqua eriqua merged commit 4529990 into Azure:main Nov 2, 2024
29 checks passed
@AlexanderSehr AlexanderSehr deleted the bulk-readme-regen branch November 2, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment