Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Orphaned modules - Leverage AVM common types module #3675

Merged
merged 19 commits into from
Nov 1, 2024

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 31, 2024

Description

Depends on #3650

Pipeline Reference

Pipeline
avm.res.analysis-services.server
avm.res.health-bot.health-bot
avm.res.healthcare-apis.workspace
avm.res.managed-services.registration-definition
avm.res.relay.namespace
avm.res.signal-r-service.web-pub-sub
avm.res.synapse.private-link-hub
avm.res.synapse.workspace
avm.res.web.connection

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 31, 2024
@eriqua eriqua self-assigned this Oct 31, 2024
@eriqua eriqua marked this pull request as ready for review November 1, 2024 19:06
@eriqua eriqua requested review from a team as code owners November 1, 2024 19:06
@eriqua eriqua requested review from a team as code owners November 1, 2024 19:06
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Nov 1, 2024
@eriqua eriqua removed Needs: Triage 🔍 Maintainers need to triage still Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Nov 1, 2024
@eriqua eriqua enabled auto-merge (squash) November 1, 2024 19:07
@eriqua eriqua merged commit 1f33c40 into Azure:main Nov 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.health-bot.health-bot
2 participants