Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove parameter composing logic from avm/res/operations-management/solution #3671

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Oct 30, 2024

Description

This PR addresses the issue with some solutions, which don't follow the naming patterns described in the template reference. To address this, the module passes the parameters to the resource provider without attempting to compose the names. It is the responsibility of the user to provide parameters expected by the resource provider. See parameter descriptions for more details.
Please note that this is a breaking change, the parameters of the existing deployments have to be updated to match the new format.

Related to #3378 (first part of the fix).

Pipeline Reference

Pipeline
avm.res.operations-management.solution

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Oct 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 30, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 30, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@krbar krbar changed the title Users/krbar/solution module update fix: remove parameter composing logic from avm/res/operations-management/solution Oct 30, 2024
@krbar krbar marked this pull request as ready for review October 30, 2024 16:47
@krbar krbar requested review from a team as code owners October 30, 2024 16:47
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 30, 2024
@AlexanderSehr AlexanderSehr merged commit 2980889 into Azure:main Oct 30, 2024
4 checks passed
@krbar krbar deleted the users/krbar/solutionModuleUpdate branch October 31, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants