Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added enforced location for ML-services #3552

Merged
merged 6 commits into from
Oct 14, 2024
Merged

fix: Added enforced location for ML-services #3552

merged 6 commits into from
Oct 14, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 14, 2024 •
edited
Loading

Description

  • Hardcoded test location to 'ukSouth' as 'NorthEurope' & 'EastAsia' are not supported

Depends on #3553

Pipeline Reference

Pipeline
avm.ptn.azd.ml-ai-environment

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Oct 14, 2024
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Pattern Module 📦 This is a pattern module AZD 🧑‍💻 These modules are requested/used by the AZD team. labels Oct 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 14, 2024
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Oct 14, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 14, 2024 19:26
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 14, 2024 19:26
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 14, 2024 19:26
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 14, 2024
eriqua
eriqua approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit b673ec8 into main Oct 14, 2024
6 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/azdaiMLLoc branch October 14, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @eriqua