Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add security compliance options for avm/res/databricks/workspace #3550

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

clintgrove
Copy link
Contributor

@clintgrove clintgrove commented Oct 14, 2024

Description

Added options to enable Security and Compliance for databricks workspaces.

EnhancedSecurityComplianceDefinition

Name Description Value
automaticClusterUpdate Status of automated cluster updates feature. AutomaticClusterUpdateDefinition
complianceSecurityProfile Status of Compliance Security Profile feature. ComplianceSecurityProfileDefinition
enhancedSecurityMonitoring Status of Enhanced Security Monitoring feature. EnhancedSecurityMonitoringDefinition

Pipeline Reference

Pipeline
avm.res.databricks.workspace

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

Name Description Value
automaticClusterUpdate Status of automated cluster updates feature. AutomaticClusterUpdateDefinition
complianceSecurityProfile Status of Compliance Security Profile feature. ComplianceSecurityProfileDefinition
enhancedSecurityMonitoring Status of Enhanced Security Monitoring feature. EnhancedSecurityMonitoringDefinition

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 14, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 14, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@clintgrove clintgrove marked this pull request as ready for review October 14, 2024 13:23
@clintgrove clintgrove requested review from a team as code owners October 14, 2024 13:23
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 14, 2024
@clintgrove
Copy link
Contributor Author

Adding a comment here, this may not be working as expected. idempotency failing on key vault error. Looking into it

AlexanderSehr
AlexanderSehr previously approved these changes Oct 14, 2024
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @clintgrove, thank your for your contribution 💪 Will hold onto the merge though, given your last comment ;)

@AlexanderSehr AlexanderSehr merged commit 0b236a5 into Azure:main Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants