Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AutomationAccount - Credential et al #3496

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 9, 2024

Description

  • Updated credential module to align with specs (singular resource deployment per module)
  • Added export for all types
  • Optimized defaults for child module

Depends on #3397

Pipeline Reference

Pipeline
avm.res.automation.automation-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Class: Resource Module 📦 This is a resource module labels Oct 9, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 9, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 9, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 15, 2024 20:38
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 15, 2024 20:38
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 15, 2024 20:38
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 15, 2024
@AlexanderSehr AlexanderSehr marked this pull request as draft October 15, 2024 20:40
auto-merge was automatically disabled October 15, 2024 20:40

Pull request was converted to draft

@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 16, 2024 11:49
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 16, 2024 11:49
@AlexanderSehr AlexanderSehr merged commit 644e64f into main Oct 16, 2024
5 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/autoAccountCredentialFix branch October 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants