Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Databricks - Aligned PE test with latest schema #3399

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 3, 2024

…be pulled into readme

Description

  • Aligned PE test with latest schema
  • Aligned code slightly to allow roles to be pulled into readme

Pipeline Reference

Pipeline
avm.res.databricks.workspace

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 3, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 3, 2024
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 3, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 3, 2024 17:02
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 3, 2024 17:02
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 3, 2024 17:03
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 3, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024

@AlexanderSehr
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

done. @clintgrove, please give the PR a look when you get the chance :)

Copy link
Contributor

@clintgrove clintgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always for your input Alex

@AlexanderSehr AlexanderSehr merged commit f850625 into main Oct 15, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/databricksPEFix branch October 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants