Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Key Vault - Fixed incorrect test value #3398

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

Fixed incorrect test value in max test that was not reflecting the way the UDTs are implemented

Pipeline Reference

Pipeline
avm.res.key-vault.vault

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Oct 3, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 3, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 3, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 3, 2024 16:52
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 3, 2024 16:52
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 3, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 3, 2024 17:02
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 3, 2024
@AlexanderSehr AlexanderSehr changed the title fix: Key Vault - Incorrect test value fix: Key Vault - Fixed incorrect test value Oct 3, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024

@AlexanderSehr
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

Done. @fblix, please give the PR a look when you get the chance :)

@AlexanderSehr AlexanderSehr merged commit 6074f32 into main Oct 15, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/kvltParamFix branch October 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants