Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support function app flex consumption plan #3390

Merged

Conversation

pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented Oct 2, 2024

Description

#3389
#3316

Pipeline Reference

Pipeline
avm.res.web.site avm.res.web.serverfarm

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@pankajagrawal16 pankajagrawal16 requested review from a team as code owners October 2, 2024 14:25
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 2, 2024
@pankajagrawal16 pankajagrawal16 changed the title Feat/3389/support function app config feat: support function app config Oct 2, 2024
@pankajagrawal16 pankajagrawal16 force-pushed the feat/3389/support-function-app-config branch 3 times, most recently from b0aa52f to fd3d7fc Compare October 2, 2024 15:18
@pankajagrawal16 pankajagrawal16 force-pushed the feat/3389/support-function-app-config branch from fd3d7fc to 635387a Compare October 3, 2024 08:33
@pankajagrawal16 pankajagrawal16 force-pushed the feat/3389/support-function-app-config branch from 635387a to ee1bb10 Compare October 3, 2024 10:30
@pankajagrawal16
Copy link
Contributor Author

@tsc-buddy Can you have a look?

Copy link
Contributor

@tsc-buddy tsc-buddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - theres a seperate ask for this to support flex consumption functions. Can you also add the appropriate Kind for FlexConsumption into this PR also.

Lets bump the minor version also.:)

@pankajagrawal16
Copy link
Contributor Author

Ok, let me have a look and will do a minor version bump

@pankajagrawal16
Copy link
Contributor Author

@tsc-buddy Are you referring to this issue? #3316

@pankajagrawal16 pankajagrawal16 requested a review from a team as a code owner October 4, 2024 08:22
@pankajagrawal16 pankajagrawal16 changed the title feat: support function app config feat: support function app flex consumption plan Oct 4, 2024
@pankajagrawal16
Copy link
Contributor Author

@tsc-buddy Updated the PR to support FlexConsumption. Have a look

@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024

@pankajagrawal16
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@tsc-buddy tsc-buddy merged commit 9510a28 into Azure:main Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants