Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added fixed uksouth and ukwest locations for avm.res.network.trafficmanagerprofile #3354

Merged
merged 29 commits into from
Sep 27, 2024
Merged

fix: Added fixed uksouth and ukwest locations for avm.res.network.trafficmanagerprofile #3354

merged 29 commits into from
Sep 27, 2024

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented Sep 24, 2024

Description

This pull request introduces fixed locations (uksouth and ukwest) used to deploy App Service plans in the waf test case due to sku family limitations

Fixes #3205
Closes #3205

Pipeline Reference

Pipeline
avm.res.network.trafficmanagerprofile

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

lsnoddy and others added 26 commits March 12, 2024 08:47
@lsnoddy
Add service-fabric cluster worklfow
f81637b
@lsnoddy
Edit workflow name
a916a14
@lsnoddy
Fixed workflow paths
5befa86
@lsnoddy
Merge branch 'anchor' of https://github.com/lsnoddy/bicep-registry-mo…
0c06b49 
…dules
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/bicep-registry-modules
f8636f2
@lsnoddy
Merge branch 'Azure:main' into main
a4beb52
@lsnoddy
Merge branch 'Azure:main' into main
f39a978
@lsnoddy
Merge branch 'Azure:main' into main
2ea25f9
@lsnoddy
Use enforcedLocation due to quota limitation in westEurope
14cd4d5
@lsnoddy
Change enforcedLocation
e024230
@lsnoddy
test eastus location
d4283f4
@lsnoddy
Update readme and json files
4f9364e
@lsnoddy
test
ada367d
@lsnoddy
test
59f9125
@lsnoddy
Enforce westus3 location due to capacity limitation
8044ed7
@lsnoddy
test
58eddea
@lsnoddy
test new location due to capacity limit
ce4752e
@lsnoddy
Update locations due to capacity limitation
523cfc4
@lsnoddy
Remove default location overwrite
431720d
@lsnoddy
test
b87c888
@lsnoddy
test
e3cf62d
@lsnoddy
test
1af6c53
@lsnoddy
Updated dependency locations due to capacity limitations
257f388
@lsnoddy
test
35e5b56
@lsnoddy
Update readme
53bf8e1
@lsnoddy
Add enforcedLocation uksouth and ukwest due to App Service plan capac…
088d778 
…ity limitation.
@lsnoddy lsnoddy added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Sep 24, 2024
@lsnoddy lsnoddy self-assigned this Sep 24, 2024
@lsnoddy lsnoddy requested a review from a team as a code owner September 24, 2024 20:22
@lsnoddy lsnoddy requested a review from a team as a code owner September 24, 2024 20:22
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Sep 24, 2024
eriqua
eriqua approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua self-assigned this Sep 26, 2024
@lsnoddy lsnoddy merged commit abd95ca into Azure:main Sep 27, 2024
4 checks passed
@lsnoddy lsnoddy deleted the users/lsnoddy/trafficmanagerprovile branch September 27, 2024 11:51
ericscheffler pushed a commit to ericscheffler/bicep-registry-modules that referenced this pull request Oct 2, 2024
@erschef
fix: Update VPN server configuration parameters
b59486d 
Updated the VPN server configuration parameters in the README.md, main.bicep, and main.json files. The `name` field for the lock has been changed to 'myCustomLockName' instead of 'ResourceLock'. Additionally, the descriptions for the `aadIssuer` and `aadTenant` parameters have been clarified. These changes ensure accurate and up-to-date information for configuring Entra ID authentication.

Related work items: Azure#3354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@lsnoddy lsnoddy

@eriqua eriqua

Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.network.trafficmanagerprofile
2 participants
@lsnoddy @eriqua