Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: static validation error and BCP error in avm.res.dev-ops-infrastructure.pool #3333

Merged
merged 4 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions avm/res/dev-ops-infrastructure/pool/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This module deploys the Managed DevOps Pool resource.
- [Usage examples](#Usage-examples)
- [Parameters](#Parameters)
- [Outputs](#Outputs)
- [Cross-referenced modules](#Cross-referenced-modules)
- [Notes](#Notes)
- [Data Collection](#Data-Collection)

## Resource Types
Expand All @@ -20,10 +20,6 @@ This module deploys the Managed DevOps Pool resource.
| `Microsoft.DevOpsInfrastructure/pools` | [2024-04-04-preview](https://learn.microsoft.com/en-us/azure/templates) |
| `Microsoft.Insights/diagnosticSettings` | [2021-05-01-preview](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Insights/2021-05-01-preview/diagnosticSettings) |

## Notes

The Managed DevOps Pool resource requires external permissions in Azure DevOps. Make sure that the deployment principal has permission in Azure DevOps: [Managed DevOps Pools - Verify Azure DevOps Permissions](https://learn.microsoft.com/en-us/azure/devops/managed-devops-pools/prerequisites?view=azure-devops&tabs=azure-portal#verify-azure-devops-permissions)

## Usage examples

The following section provides usage examples for the module, which were used to validate and deploy the module successfully. For a full reference, please review the module's test folder in its repository.
Expand Down Expand Up @@ -544,7 +540,6 @@ module pool 'br/public:avm/res/dev-ops-infrastructure/pool:<version>' = {
</details>
<p>


## Parameters

**Required parameters**
Expand Down Expand Up @@ -758,7 +753,7 @@ Group email addresses.

Determines who has admin permissions to the Azure DevOps pool.

- Required: No
- Required: Yes
- Type: string
- Allowed:
```Bicep
Expand Down Expand Up @@ -1104,6 +1099,12 @@ Array of role assignments to create.

- Required: No
- Type: array
- Roles configurable by name:
- `'Contributor'`
- `'Owner'`
- `'Reader'`
- `'Role Based Access Control Administrator (Preview)'`
- `'User Access Administrator'`

**Required parameters**

Expand Down Expand Up @@ -1300,7 +1301,6 @@ Tags of the resource.
- Required: No
- Type: object


## Outputs

| Output | Type | Description |
Expand All @@ -1311,9 +1311,9 @@ Tags of the resource.
| `resourceId` | string | The resource ID of the Managed DevOps Pool. |
| `systemAssignedMIPrincipalId` | string | The principal ID of the system assigned identity. |

## Cross-referenced modules
## Notes

_None_
The Managed DevOps Pool resource requires external permissions in Azure DevOps. Make sure that the deployment principal has permission in Azure DevOps: [Managed DevOps Pools - Verify Azure DevOps Permissions](https://learn.microsoft.com/en-us/azure/devops/managed-devops-pools/prerequisites?view=azure-devops&tabs=azure-portal#verify-azure-devops-permissions)

## Data Collection

Expand Down
2 changes: 1 addition & 1 deletion avm/res/dev-ops-infrastructure/pool/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ type organizationProfileType = {
@description('Optional. The type of permission which determines which accounts are admins on the Azure DevOps pool.')
permissionProfile: {
@description('Optional. Determines who has admin permissions to the Azure DevOps pool.')
ReneHezser marked this conversation as resolved.
Show resolved Hide resolved
kind: ('CreatorOnly' | 'Inherit' | 'SpecificAccounts')?
kind: 'CreatorOnly' | 'Inherit' | 'SpecificAccounts'

@description('Optional. Group email addresses.')
groups: string[]?
Expand Down
5 changes: 2 additions & 3 deletions avm/res/dev-ops-infrastructure/pool/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "9138966756251042726"
"version": "0.30.3.12046",
"templateHash": "1491249419213111171"
},
"name": "Managed DevOps Pool",
"description": "This module deploys the Managed DevOps Pool resource.",
Expand Down Expand Up @@ -189,7 +189,6 @@
"Inherit",
"SpecificAccounts"
],
"nullable": true,
"metadata": {
"description": "Optional. Determines who has admin permissions to the Azure DevOps pool."
}
Expand Down