Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new ptn modules avm/ptn/azd/container-app-upsert #3260

Merged
merged 7 commits into from
Oct 12, 2024
Merged

feat: Add new ptn modules avm/ptn/azd/container-app-upsert #3260

merged 7 commits into from
Oct 12, 2024

Conversation

NanaXiong00
Copy link
Contributor

@NanaXiong00 NanaXiong00 commented Sep 13, 2024 •
edited
Loading

Description

Fixes Azure/Azure-Verified-Modules#1222

Pipeline Reference

Pipeline
avm.ptn.azd.container-app-upsert

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio for notification.

@NanaXiong00
Create avm.ptn.azd.container-app.yml
5dc2ebc
@NanaXiong00
Merge branch 'Azure:main' into main
e9a1998
@NanaXiong00
Create ptn module container-app-upsert
c17a16b 
fix format

update max test

add location

update module

add dependence resource

update test name

add param identityPrincipalId

add param userAssignedIdentityResourceId

add keyvault roleAssignment

update desc
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 13, 2024
@matebarabas matebarabas changed the title feat: Add new ptn modules azd/container-app-upsert feat: Add new ptn modules avm/ptn/azd/container-app-upsert Sep 18, 2024
@eriqua eriqua added Needs: Core Team 🧞 This item needs the AVM Core Team to review it AZD 🧑‍💻 These modules are requested/used by the AZD team. labels Sep 27, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024 •
edited
Loading

@NanaXiong00
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@NanaXiong00 NanaXiong00 marked this pull request as ready for review October 12, 2024 02:15
@NanaXiong00 NanaXiong00 requested review from a team as code owners October 12, 2024 02:15
AlexanderSehr
AlexanderSehr approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creat work @NanaXiong00 , nothing to call out. Off we go 💪

@AlexanderSehr AlexanderSehr merged commit 4b99f59 into Azure:main Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@AlexanderSehr AlexanderSehr

@NanaXiong00 NanaXiong00

Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: avm/ptn/azd/container-app-upsert
4 participants
@NanaXiong00 @ReneHezser @AlexanderSehr @eriqua